Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In keeping with our goal to be consistent with
numpy
, this PR changes the behavior for several methods to returntuple
rather than lists ornumpy.ndarray
. This includes:pyvista.DataSet.bounds
list
->tuple
pyvista.DataSet.extent
list
->tuple
pyvista.DataSet.cell_bounds
list
->tuple
pyvista.Grid.dimensions
list
->tuple
pyvista.UniformGrid.origin
list
->tuple
pyvista.UniformGrid.spacing
list
->tuple
pyvista.ExplicitStructuredGrid.spacing
np.ndarray
->tuple
pyvista.ExplicitStructuredGrid.visible_bounds
list
->tuple
Why?
There's no reason for returning a
list
, which are more flexible than tuples and imply that there's a reason to append or manipulate the data. Rather, the immutability of thetuple
implies that the data returned is "read only". And because VTK already returnstuple
s as the default datatype forGetBounds
and other class methods, this actually simplifies our code. Plus, this matchesnumpy
'sshape
,ndim
and other properties.Other Changes
ExplicitStructuredGrid.hide_cells
andshow_cells
now accepts sequences rather than justnumpy.ndarray
.grid.py
in several places, including adding examples to the docstrings.UniformGrid
with negative spacing results in wrong subset when usingextract_subset
#1967 by disallowing negative spacing.