Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ipython requirement from <8.0.0 to <9.0.0 #2056

Merged
merged 2 commits into from
Mar 19, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 21, 2022

Updates the requirements on ipython to permit the latest version.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the maintenance Low-impact maintenance activity label Jan 21, 2022
@dependabot dependabot bot force-pushed the dependabot/pip/ipython-lt-9.0.0 branch from 9e3fa58 to 7a63785 Compare January 21, 2022 19:57
@adeak
Copy link
Member

adeak commented Jan 21, 2022

Nice try, dependabot. (OK, I guess there's an 8.0.1 version out; let's see if it works.)

@akaszynski
Copy link
Member

Nice try, dependabot. (OK, I guess there's an 8.0.1 version out; let's see if it works.)

Seems the issue remains with ipython==8.0.1. So, I guess this works, but it would be preferable if you can control the sem version MAJOR/MINOR/PATCH it attempts to limit.

@adeak
Copy link
Member

adeak commented Jan 22, 2022

Seems the issue remains with ipython==8.0.1

Yeah, from the commit log posted by dependabot it seems that this is just a security patch release. The fix to our problem seems to be planned for 8.1.

@MatthewFlamm
Copy link
Contributor

MatthewFlamm commented Jan 24, 2022

This sort of thing is going to be a pain with < or <= pinning.
This PR would pass once 8.1.0 is released (assuming it is fixed in that version) even though it won't for 8.0.1.

Maybe revisit when we drop 3.6 though

@dependabot dependabot bot force-pushed the dependabot/pip/ipython-lt-9.0.0 branch from 7a63785 to 712ce1c Compare January 25, 2022 15:02
@banesullivan
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/pip/ipython-lt-9.0.0 branch from 712ce1c to 39e8e7e Compare January 30, 2022 17:27
@banesullivan banesullivan marked this pull request as draft January 30, 2022 18:36
@dependabot dependabot bot force-pushed the dependabot/pip/ipython-lt-9.0.0 branch 2 times, most recently from 9b82925 to 03f88c7 Compare February 14, 2022 10:12
Updates the requirements on [ipython](https://github.com/ipython/ipython) to permit the latest version.
- [Release notes](https://github.com/ipython/ipython/releases)
- [Commits](ipython/ipython@rel-0.8.4...8.0.1)

---
updated-dependencies:
- dependency-name: ipython
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/ipython-lt-9.0.0 branch from 03f88c7 to fefa649 Compare February 14, 2022 10:12
@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

Merging #2056 (96ff75d) into main (eddd91a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2056   +/-   ##
=======================================
  Coverage   93.51%   93.51%           
=======================================
  Files          74       74           
  Lines       15737    15737           
=======================================
  Hits        14716    14716           
  Misses       1021     1021           

@akaszynski akaszynski marked this pull request as ready for review March 19, 2022 11:57
@akaszynski akaszynski merged commit f99bad6 into main Mar 19, 2022
@akaszynski akaszynski deleted the dependabot/pip/ipython-lt-9.0.0 branch March 19, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants