Fix CONTRIBUTING.rst and mention black #2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
adeak
commented
Feb 19, 2022
Codecov Report
@@ Coverage Diff @@
## main #2241 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 75 75
Lines 15602 15602
=======================================
Hits 14558 14558
Misses 1044 1044 |
tkoyama010
requested changes
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some broken formatting left after the markdown -> reST overhaul of the contributing guide. I also don't know why every link has double underlines at the end: as far as I know only one is necessary for links. But the rendered html works fine so I didn't touch these.
I've also added a note about
blackbeing in use and changed themake isortsuggestion into amake formatone.We should check the doc artifact of this PR before merging to see if I got everything right, I haven't built it locally this time.