Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CONTRIBUTING.rst some more #2244

Merged
merged 1 commit into from
Feb 20, 2022

Conversation

adeak
Copy link
Member

@adeak adeak commented Feb 19, 2022

Further cleanup after #2241. Please don't merge until I've had a chance to look at the built docs to verify that nothing else is broken. cc @tkoyama010 :)

@github-actions github-actions bot added the documentation Anything related to the documentation/website label Feb 19, 2022
@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #2244 (be69012) into main (2df0690) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2244   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files          75       75           
  Lines       15602    15602           
=======================================
  Hits        14558    14558           
  Misses       1044     1044           

@adeak
Copy link
Member Author

adeak commented Feb 19, 2022

Built docs look good, this is ready for review, thanks.

Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies. I mistakenly thought you had already confirmed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants