-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add clip box example to docstring #2547
Conversation
Added an example clip box to the doc string and a reference to the example page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thanks for opening your first pull request in PyVista! 🚀 Please make sure you read (skim 😉) our Contributing Guide and abide by our Code of Conduct.
A few things to keep in mind:
- Remember to run the tests locally to make debugging issues easier.
- If you need help writing tests, take a look at the existing ones for inspiration. If you do not know where to start, let
@pyvista/developers
know and we will walk you through it. - All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
- No matter what, we are really grateful that you put in the effort to open this PR! ⭐
Co-authored-by: MatthewFlamm <39341281+MatthewFlamm@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Codecov Report
@@ Coverage Diff @@
## main #2547 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 75 75
Lines 16159 16159
=======================================
Hits 15140 15140
Misses 1019 1019 |
Turns out our box widget isn't being collected. I'm working on a fix. |
Merge with main once #2569 is merged. |
This should now run correctly with #2569. Calling this good to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docstring testing failure appears to be a fluke, but will keep an eye out for it now. Ran three times to be sure.
Overview
Added an example clip box to the doc string and a reference to the box clip example page