Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checkbox widget example #2550

Merged
merged 14 commits into from
May 3, 2022
Merged

Conversation

yungchidanielcho
Copy link
Contributor

Overview

Add a simple example and a reference link to the full example page for checkbox widget example

Added a Sphinx reference name to checkbox_widget example page
#2549

Add an simple example and a reference to the full example page for checkbox widget example
@github-actions github-actions bot added the bug Uh-oh! Something isn't working as expected. label May 2, 2022
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #2550 (af33b54) into main (f1f4df2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2550   +/-   ##
=======================================
  Coverage   93.72%   93.72%           
=======================================
  Files          75       75           
  Lines       16120    16120           
=======================================
  Hits        15108    15108           
  Misses       1012     1012           

@adeak
Copy link
Member

adeak commented May 2, 2022

Thank you for these PRs. You can also gather all these changes (i.e. this and #2547 and #2549) into a single PR for ease of handling :) They are closely related anyway.

@yungchidanielcho
Copy link
Contributor Author

Thank you for these PRs. You can also gather all these changes (i.e. this and #2547 and #2549) into a single PR for ease of handling :) They are closely related anyway.

Ok I’ll do that.

@akaszynski akaszynski changed the title Update widgets.py add checkbox widget example May 2, 2022
@akaszynski
Copy link
Member

Thank you for these PRs. You can also gather all these changes (i.e. this and #2547 and #2549) into a single PR for ease of handling :) They are closely related anyway.

Merged #2549 before seeing this. Sorry!

yungchidanielcho and others added 2 commits May 2, 2022 20:48
Accept changes to fix format and typo

Co-authored-by: Alex Kaszynski <akascap@gmail.com>
@adeak adeak added documentation Anything related to the documentation/website and removed bug Uh-oh! Something isn't working as expected. labels May 2, 2022
pyvista/plotting/widgets.py Outdated Show resolved Hide resolved
pyvista/plotting/widgets.py Outdated Show resolved Hide resolved
pyvista/plotting/widgets.py Outdated Show resolved Hide resolved
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
pyvista/plotting/widgets.py Outdated Show resolved Hide resolved
pyvista/plotting/widgets.py Outdated Show resolved Hide resolved
pyvista/plotting/widgets.py Outdated Show resolved Hide resolved
Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks!

@akaszynski akaszynski merged commit 537d4b9 into pyvista:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants