Add community-reviewed label is need to merge

[tkoyama010]

Overview

The PyVista community has grown and also the developer community has grown. Nowadays, pull requests are reviewed from multiple locations around the world. Every time zone in the world should have an equal opportunity to review PyVista's pull request. In other words, reviewers should be granted their chance to review for at least 1 day. However, maintainers, myself included, tend to be aggressive in merging (because we want to improve PyVista quickly!). It is also painful to open an uncommented PullRequest after a day pass even though there is an enable auto-merge.

So I built a system to solve this problem with GitHub Action. This system is divided into two parts.

1. Community Review: Here the label community-reviewed is added one day after the last action in the PullRequest. If someone takes some action, it will wait another day. If someone comments, the community-reviewed label is removed and a do-not-merge label is added. This label prevents merging, so please remove it when the discussion is over. You can also add it when you feel a long time discussion is needed.

2. Pull Request Labels: Here we check the labels required for the merge, blocking the merge if they do not meet the criteria. The label community-reviewed, which is given if 1. is passed, is a required label. do-not-merge is a label that must not exist to merge. We also need a required label for release notes. This solves the problem of Fix GitHub Action's expression #2453 .

Please review as there may be use cases that I am not anticipating. Reviews are always important!!!

relate to #2245

resolves #2774

Details

• https://github.com/marketplace/actions/close-stale-issues
• https://github.com/marketplace/actions/require-labels

[adeak]

I won't be able to review this PR, but as someone who lives on the other side of the planet (well, active in time zones on the other side of the planet), this is much appreciated :) Thanks for all the work you put into this.

[codecov]

Codecov Report

Merging #2851 (8224cfd) into main (1bd5689) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2851   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files          76       76           
  Lines       16399    16399           
=======================================
  Hits        15420    15420           
  Misses        979      979           

[tkoyama010]

@adeak Thanks. This PR was largely inspired by your "Improving review habit" thread.

[tkoyama010]

As a matter of course, the Pull Request result is always red before community-reviewd label is added. I need to change my habits as I tend not to review until CI is green.

[akaszynski]

Cool! I'm going to approve and see if automerge works after 24 hr.

[akaszynski]

Whelp. Forgot to add the label as a merge requirement.

[akaszynski]

"triage" added as a merge requirement.

[tkoyama010]

@akaszynski Thanks.