Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add community-reviewed label is need to merge" #2860

Merged
merged 3 commits into from
Jun 25, 2022

Conversation

tkoyama010
Copy link
Member

@tkoyama010 tkoyama010 commented Jun 25, 2022

Reverts #2851
See #2857

Resolves #2855

@tkoyama010 tkoyama010 marked this pull request as ready for review June 25, 2022 20:52
Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this didn't work out @tkoyama010, but I appreciate your efforts nonetheless.

Let's ask GitHub for a timer for automerge, that would be awesome!

@adeak
Copy link
Member

adeak commented Jun 25, 2022

Indeed, thanks again @tkoyama010 for labouring with this attempt to make the review workflow smoother.

@tkoyama010
Copy link
Member Author

Thanks for the comments. I love challenges like this. The ability to check the required labels in the release notes was a great accomplishment we got this time. I will reflect on this part after merging this.

.github/workflows/label.yml Outdated Show resolved Hide resolved
.github/workflows/label.yml Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #2860 (b3666f5) into main (d1e17d3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2860   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files          76       76           
  Lines       16399    16399           
=======================================
  Hits        15420    15420           
  Misses        979      979           

@github-actions github-actions bot added the maintenance Low-impact maintenance activity label Jun 25, 2022
@tkoyama010 tkoyama010 added maintenance Low-impact maintenance activity and removed maintenance Low-impact maintenance activity labels Jun 25, 2022
@tkoyama010
Copy link
Member Author

For Reverts, no review is required, so the 24-hour rule is not applied and the merge is performed.

@tkoyama010 tkoyama010 enabled auto-merge (squash) June 25, 2022 21:30
@tkoyama010 tkoyama010 merged commit 5f3da83 into main Jun 25, 2022
@tkoyama010 tkoyama010 deleted the revert-2851-maint/github-action-required-labels branch June 25, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Red check label triage
3 participants