Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some decimate_pro arguments #2874

Merged
merged 5 commits into from
Jun 28, 2022
Merged

add some decimate_pro arguments #2874

merged 5 commits into from
Jun 28, 2022

Conversation

darikg
Copy link
Contributor

@darikg darikg commented Jun 26, 2022

Add support for boundary vertex deletion and max vertex degree parameters

@akaszynski
Copy link
Member

@tkoyama010, do you know why the triage workflow is still failing?

@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #2874 (3726c6f) into main (22dc22e) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2874      +/-   ##
==========================================
- Coverage   94.09%   94.04%   -0.06%     
==========================================
  Files          76       76              
  Lines       16426    16429       +3     
==========================================
- Hits        15456    15450       -6     
- Misses        970      979       +9     

@tkoyama010
Copy link
Member

@akaszynski In this case, the reason is this PR doesn't have any labels.

@tkoyama010 tkoyama010 added the enhancement Changes that enhance the library label Jun 26, 2022
@akaszynski
Copy link
Member

@akaszynski In this case, the reason is this PR doesn't have any labels.

Suggesting resolving this with #2877

@tkoyama010 tkoyama010 added testing Anything related to CI testing and removed testing Anything related to CI testing labels Jun 27, 2022
Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@akaszynski akaszynski merged commit c6f26c9 into pyvista:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes that enhance the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants