Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for labels. #2877

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Remove need for labels. #2877

merged 1 commit into from
Jun 27, 2022

Conversation

akaszynski
Copy link
Member

@akaszynski akaszynski commented Jun 26, 2022

Remove required labels. This is broken for fresh PRs and should be disabled until mheap/github-action-required-labels#33 is resolved.

Would like your input @tkoyama010.

@github-actions github-actions bot added the maintenance Low-impact maintenance activity label Jun 26, 2022
@akaszynski akaszynski changed the title Update label.yml Remove need for labels. Jun 26, 2022
@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #2877 (61cd996) into main (d3a51be) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2877   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files          76       76           
  Lines       16426    16426           
=======================================
  Hits        15447    15447           
  Misses        979      979           

@tkoyama010
Copy link
Member

tkoyama010 commented Jun 26, 2022

The decision to add this was a mistake, as it is something that can be checked when creating the release notes to see if all pull requests are labeled.

@banesullivan
Copy link
Member

Merging this.

@banesullivan banesullivan merged commit 22dc22e into main Jun 27, 2022
@banesullivan banesullivan deleted the ci/remove_required_labels branch June 27, 2022 17:09
@banesullivan
Copy link
Member

I was a couple hours shy of 24, but this is causing failed CIs on all PRs

@akaszynski
Copy link
Member Author

I was a couple hours shy of 24, but this is causing failed CIs on all PRs

Fully agree.

tkoyama010 added a commit that referenced this pull request Jun 27, 2022
tkoyama010 added a commit that referenced this pull request Jun 28, 2022
tkoyama010 added a commit that referenced this pull request Jun 28, 2022
@tkoyama010 tkoyama010 mentioned this pull request Jun 28, 2022
1 task
tkoyama010 added a commit that referenced this pull request Jun 28, 2022
* Additional revert of #2877

* Update label.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants