Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build documentation using Python 3.9 and latest OSMesa wheel #2876

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

akaszynski
Copy link
Member

@akaszynski akaszynski commented Jun 26, 2022

In support of #2839, this PR updates the documentation build to use the latest Python 3.9 OSMesa wheel built on Ubuntu 22.04 20.04. This wheel was built following VTK's build procedures, as noted in the updated PyVista-Wheels README.

@github-actions github-actions bot added the maintenance Low-impact maintenance activity label Jun 26, 2022
@akaszynski akaszynski changed the title nn Build documentation using Python 3.9 and latest OSMesa wheel Jun 26, 2022
@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #2876 (60489c6) into main (19ff4f0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2876   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files          76       76           
  Lines       16426    16426           
=======================================
  Hits        15447    15447           
  Misses        979      979           

@akaszynski
Copy link
Member Author

I've already reverted the changes to the Python 3.9 wheel; it needs to be rebuilt on Ubuntu 20.04. The glibc of what I'm running is too new and I'll have to build on 20.04 to get it to work on 22.04 for sure.

Another reminder why to use manylinux and this is just a hack to get OSMesa wheels.

@akaszynski akaszynski mentioned this pull request Jun 27, 2022
2 tasks
@akaszynski
Copy link
Member Author

This is good to go and needed for #2839. Would appreciate a review soon.

Copy link
Member

@adeak adeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a good look at the build artifact, nothing out of the ordinary stood out to me. Examples, doctests, known bugs still seem to be there as on dev.pyvista.org. So overall this LGTM.

@tkoyama010 tkoyama010 mentioned this pull request Jun 28, 2022
1 task
@tkoyama010 tkoyama010 merged commit 3b22d39 into main Jun 28, 2022
@tkoyama010 tkoyama010 deleted the ci/use_py39 branch June 28, 2022 11:43
adeak added a commit to adeak/pyvista that referenced this pull request Jun 28, 2022
* upstream/main:
  use python 3.9 with new osmesa wheel (pyvista#2876)
  Update hypothesis requirement from <6.47.6 to <6.48.2 (pyvista#2895)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants