Additional revert of #2877 #2893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkoyama010
commented
Jun 28, 2022
Codecov Report
@@ Coverage Diff @@
## main #2893 +/- ##
=======================================
Coverage 94.04% 94.04%
=======================================
Files 76 76
Lines 16428 16428
=======================================
Hits 15449 15449
Misses 979 979 |
|
I have checked Blame to make sure there are no Revert leaks. |
|
Just to be sure, will this solve the issue? We're on the fourth PR for this, can we check this on a fork or something and reproduce the issue? |
|
@akaszynski Absolutely. I made a copied repository of pyvsita in my account. Could you check if the error is reproduced by your Pull Request to it? After that, we can merge tkoyama010#1 and check if it is solved. |
akaszynski
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Additional revert of #2877
Details