Resolve issues with scalars in cell_data_to_point_data API docs #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update PyVista forked repo
|
Pinging @tkoyama010 @akaszynski for review |
|
FYI, local version of the docs. Now the API example will look like this
|
Codecov Report
@@ Coverage Diff @@
## main #3011 +/- ##
=======================================
Coverage 94.34% 94.34%
=======================================
Files 76 76
Lines 16546 16548 +2
=======================================
+ Hits 15610 15612 +2
Misses 936 936 |
akaszynski
pushed a commit
that referenced
this pull request
Jul 18, 2022
Merged
akaszynski
added a commit
that referenced
this pull request
Jul 18, 2022
* Add camera position example (#3019) * Add example camera_position property Add example for camera_position property per issue #1629. * Add background_color property example Add example for background_color property per issue #1629. * Apply suggestions from code review Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> * Fix by pre-commit run --all-files * Update pyvista/plotting/plotting.py Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> * Update pyvista/plotting/plotting.py Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> * Update pyvista/plotting/plotting.py Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> * Update pyvista/plotting/plotting.py Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> * Update pyvista/plotting/plotting.py Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> * Add background_color example Add example for background_color property. * clean up example * Update pyvista/plotting/plotting.py Co-authored-by: ENIAC-6 <kellysmeehan@gmail.com> Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> * Clear charts when clearing plotters (#2991) * Clean charts when clearing a renderer * Add test for charts clearing via plotter clear * Deep clean charts before destruction * Simplify plotter._renderer reference in chart tests * Don't create a Charts on clear() * Update pyvista/plotting/charts.py Co-authored-by: Alex Kaszynski <akascap@gmail.com> * Include area values in the images (#3011) * Fix pyvista.plot kwargs (#2967) * fix helpers kwargs * improve coverage * add missing image cache * skip windows cache verification of volume rendering * Add background_color example (#3013) * Add background_color example Add example to background_color property. * clean up example a bit Co-authored-by: Alex Kaszynski <akascap@gmail.com> * Fix the flying edges example (#3014) * fix the flying edges_example * Update examples/01-filter/flying_edges.py Co-authored-by: Andras Deak <adeak@users.noreply.github.com> Co-authored-by: Andras Deak <adeak@users.noreply.github.com> * Added link_views example (#3016) * added link_views() example * Apply suggestions from code review Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> * link views example update * Apply suggestions from code review Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> * Apply suggestions from code review Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> * Removing docstring and return statement (#2999) * Removing docstring and return statement * Add export object test * Pre-commit hooks * fix path of obj writer Co-authored-by: Alex Kaszynski <akascap@gmail.com> Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> * Add example remove_scalar_bar( ) (#3005) * Example remove_scalar_bar( ) Add example for remove_scalar_bar( ) for plotting module to address issue #1629. * move to ScalarBar * Update pyvista/plotting/scalar_bars.py * Update pyvista/plotting/scalar_bars.py Co-authored-by: Alex Kaszynski <akascap@gmail.com> * Fixed docstring explanation for curvature function (#2997) * Add movie glyphs example (#2981) * add movie glyphs * add movie glyphs example * fix ref * Update examples/02-plot/movie_glyphs.py Co-authored-by: MatthewFlamm <39341281+MatthewFlamm@users.noreply.github.com> Co-authored-by: MatthewFlamm <39341281+MatthewFlamm@users.noreply.github.com> * Fix texture docstring (#2996) * Fix active plotting scalars for multi-plots (#2980) * fix active plotting scalars * fix active plotting scalars * fix docstring * fix metadata copy * remove return change * fix none return * [BUG] Fix clearing point and cell data (#2976) * [BUG] Fix clearning point and cell data * remove mesh data clear * Add regression test for mesh fiddling in deep_clean() Co-authored-by: Alex Kaszynski <akascap@gmail.com> Co-authored-by: Andras Deak <deak.andris@gmail.com> * add more mount damavand examples (#2969) * add more mount damavand examples * Update pyvista/examples/downloads.py * Apply suggestions from code review Co-authored-by: Andras Deak <adeak@users.noreply.github.com> * fix image cache * bump to v0.35.2 Co-authored-by: ENIAC-6 <kellysmeehan@gmail.com> Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> Co-authored-by: Andras Deak <adeak@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <roberto.pastormuela@ansys.com> Co-authored-by: charithgunasekara <106762598+charithgunasekara@users.noreply.github.com> Co-authored-by: MatthewFlamm <39341281+MatthewFlamm@users.noreply.github.com> Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com> Co-authored-by: Alex Rockhill <aprockhill@mailbox.org> Co-authored-by: Andras Deak <deak.andris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #1625
Details
After some testing, it was seen that the Area values were not being shown. The bug fix consisted on including the
Areaas ascalarsto be plotted. This was also fixed in the API docs forcompute_cell_sizes(). Smooth shading has also been deactivated to provide more visual information regarding the cell/point values.