Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add camera position example #3019

Merged
merged 14 commits into from Jul 18, 2022
Merged

Add camera position example #3019

merged 14 commits into from Jul 18, 2022

Conversation

akaszynski
Copy link
Member

This PR extends #3010 by cleaning up the example and adding the additional language = 'en' needed to enable documentation caching.

Thanks @ENIAC-6!

ENIAC-6 and others added 13 commits July 17, 2022 08:55
Add example for camera_position property per issue #1629.
Add example for background_color property per issue #1629.
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
Add example for background_color property.
@github-actions github-actions bot added the documentation Anything related to the documentation/website label Jul 17, 2022
@akaszynski akaszynski added this to the 0.35.2 milestone Jul 17, 2022
@akaszynski akaszynski added the scipy2022 Sprint in scipy2022. label Jul 17, 2022
pyvista/plotting/plotting.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 17, 2022

Codecov Report

Merging #3019 (537b678) into main (38639a3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3019   +/-   ##
=======================================
  Coverage   94.37%   94.37%           
=======================================
  Files          76       76           
  Lines       16541    16541           
=======================================
  Hits        15611    15611           
  Misses        930      930           

@akaszynski
Copy link
Member Author

Merging this for a 0.35.2 patch release. Thanks for catching the docstring issue @adeak.

@akaszynski akaszynski merged commit 200864e into main Jul 18, 2022
@akaszynski akaszynski deleted the doc/camera_position_example branch July 18, 2022 00:31
akaszynski added a commit that referenced this pull request Jul 18, 2022
* Add example camera_position property

Add example for camera_position property per issue #1629.

* Add background_color property example

Add example for background_color property per issue #1629.

* Apply suggestions from code review

Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>

* Fix by pre-commit run --all-files

* Update pyvista/plotting/plotting.py

Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>

* Update pyvista/plotting/plotting.py

Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>

* Update pyvista/plotting/plotting.py

Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>

* Update pyvista/plotting/plotting.py

Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>

* Update pyvista/plotting/plotting.py

Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>

* Add background_color example

Add example for background_color property.

* clean up example

* Update pyvista/plotting/plotting.py

Co-authored-by: ENIAC-6 <kellysmeehan@gmail.com>
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
@akaszynski akaszynski mentioned this pull request Jul 18, 2022
akaszynski added a commit that referenced this pull request Jul 18, 2022
* Add camera position example (#3019)

* Add example camera_position property

Add example for camera_position property per issue #1629.

* Add background_color property example

Add example for background_color property per issue #1629.

* Apply suggestions from code review

Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>

* Fix by pre-commit run --all-files

* Update pyvista/plotting/plotting.py

Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>

* Update pyvista/plotting/plotting.py

Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>

* Update pyvista/plotting/plotting.py

Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>

* Update pyvista/plotting/plotting.py

Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>

* Update pyvista/plotting/plotting.py

Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>

* Add background_color example

Add example for background_color property.

* clean up example

* Update pyvista/plotting/plotting.py

Co-authored-by: ENIAC-6 <kellysmeehan@gmail.com>
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>

* Clear charts when clearing plotters (#2991)

* Clean charts when clearing a renderer

* Add test for charts clearing via plotter clear

* Deep clean charts before destruction

* Simplify plotter._renderer reference in chart tests

* Don't create a Charts on clear()

* Update pyvista/plotting/charts.py

Co-authored-by: Alex Kaszynski <akascap@gmail.com>

* Include area values in the images (#3011)

* Fix pyvista.plot kwargs (#2967)

* fix helpers kwargs

* improve coverage

* add missing image cache

* skip windows cache verification of volume rendering

* Add background_color example (#3013)

* Add background_color example

Add example to background_color property.

* clean up example a bit

Co-authored-by: Alex Kaszynski <akascap@gmail.com>

* Fix the flying edges example (#3014)

* fix the flying edges_example

* Update examples/01-filter/flying_edges.py

Co-authored-by: Andras Deak <adeak@users.noreply.github.com>

Co-authored-by: Andras Deak <adeak@users.noreply.github.com>

* Added link_views example (#3016)

* added link_views() example

* Apply suggestions from code review

Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>

* link views example update

* Apply suggestions from code review

Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>

* Apply suggestions from code review

Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>

* Removing docstring and return statement (#2999)

* Removing docstring and return statement

* Add export object test

* Pre-commit hooks

* fix path of obj writer

Co-authored-by: Alex Kaszynski <akascap@gmail.com>
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>

* Add example remove_scalar_bar( ) (#3005)

* Example remove_scalar_bar( )

Add example for remove_scalar_bar( ) for plotting module to address issue #1629.

* move to ScalarBar

* Update pyvista/plotting/scalar_bars.py

* Update pyvista/plotting/scalar_bars.py

Co-authored-by: Alex Kaszynski <akascap@gmail.com>

* Fixed docstring explanation for curvature function (#2997)

* Add movie glyphs example (#2981)

* add movie glyphs

* add movie glyphs example

* fix ref

* Update examples/02-plot/movie_glyphs.py

Co-authored-by: MatthewFlamm <39341281+MatthewFlamm@users.noreply.github.com>

Co-authored-by: MatthewFlamm <39341281+MatthewFlamm@users.noreply.github.com>

* Fix texture docstring (#2996)

* Fix active plotting scalars for multi-plots (#2980)

* fix active plotting scalars

* fix active plotting scalars

* fix docstring

* fix metadata copy

* remove return change

* fix none return

* [BUG] Fix clearing point and cell data (#2976)

* [BUG] Fix clearning point and cell data

* remove mesh data clear

* Add regression test for mesh fiddling in deep_clean()

Co-authored-by: Alex Kaszynski <akascap@gmail.com>
Co-authored-by: Andras Deak <deak.andris@gmail.com>

* add more mount damavand examples (#2969)

* add more mount damavand examples

* Update pyvista/examples/downloads.py

* Apply suggestions from code review

Co-authored-by: Andras Deak <adeak@users.noreply.github.com>

* fix image cache

* bump to v0.35.2

Co-authored-by: ENIAC-6 <kellysmeehan@gmail.com>
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <roberto.pastormuela@ansys.com>
Co-authored-by: charithgunasekara <106762598+charithgunasekara@users.noreply.github.com>
Co-authored-by: MatthewFlamm <39341281+MatthewFlamm@users.noreply.github.com>
Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com>
Co-authored-by: Alex Rockhill <aprockhill@mailbox.org>
Co-authored-by: Andras Deak <deak.andris@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website scipy2022 Sprint in scipy2022.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants