-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add constrained triangulation example #3448
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3448 +/- ##
==========================================
- Coverage 95.16% 95.16% -0.01%
==========================================
Files 83 83
Lines 18476 18474 -2
==========================================
- Hits 17583 17581 -2
Misses 893 893 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to plot comb
before the triangulation to give more context
Otherwise, nice addition!
Suddenly seeing instability with:
Looks like a charts issue, but it's unclear what's causing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. I am excited about this example.
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
Going ahead and merging this. Would like to get the release process out soon and changes have been implemented. Thanks @banesullivan and @tkoyama010 for your reviews! |
The docstring of the
delaunay_2d
filter is missing a constrained tesselation example.As a bonus, converts
optional
todefault
in the docstring of this method.