Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] VTK 9.0.3 + NumPy<1.24 CI #3729

Merged
merged 1 commit into from
Dec 19, 2022
Merged

[HOTFIX] VTK 9.0.3 + NumPy<1.24 CI #3729

merged 1 commit into from
Dec 19, 2022

Conversation

banesullivan
Copy link
Member

NumPy 1.24.0 was released yesterday which deprecated np.bool. VTK 9.0.3 relied on that:

/opt/hostedtoolcache/Python/3.8.15/x64/lib/python3.8/site-packages/vtkmodules/util/numpy_support.py:216: in vtk_to_numpy
    assert typ in get_vtk_to_numpy_typemap().keys(), \
/opt/hostedtoolcache/Python/3.8.15/x64/lib/python3.8/site-packages/vtkmodules/util/numpy_support.py:74: in get_vtk_to_numpy_typemap
    _vtk_np = {vtkConstants.VTK_BIT:numpy.bool,
/opt/hostedtoolcache/Python/3.8.15/x64/lib/python3.8/site-packages/numpy/__init__.py:284: in __getattr__
    raise AttributeError("module {!r} has no attribute "
E   AttributeError: module 'numpy' has no attribute 'bool'

These changes limit NumPy for our VTK 9.0.3 CI

@github-actions github-actions bot added the maintenance Low-impact maintenance activity label Dec 19, 2022
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #3729 (1134817) into main (2826168) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3729   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files          83       83           
  Lines       18641    18641           
=======================================
  Hits        17530    17530           
  Misses       1111     1111           

@banesullivan
Copy link
Member Author

Tis a hotfix, so I'm merging with just the necessary CI passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant