Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Use latest VTK version for conda tests #3736

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Conversation

banesullivan
Copy link
Member

The conda tests were using VTK 8.2... why? This updates conda to use whatever the latest version is which seems most appropriate to me. Other versions of VTK are checked in other CI routines.

Either way, this needs to be updated because VTK8.2.2 is incompatible with the latest NumPy 1.24

@pyvista/developers, I plan on merging this quickly to fix broken CI

@github-actions github-actions bot added the maintenance Low-impact maintenance activity label Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #3736 (77da0ca) into main (4bc2064) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3736   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files          83       83           
  Lines       18643    18643           
=======================================
  Hits        17532    17532           
  Misses       1111     1111           

@banesullivan
Copy link
Member Author

This cannot pass until #3737 merges

@akaszynski
Copy link
Member

We were testing conda using vtk==8.2 because it was the only way we could actually test that 8.2 works. It's a hard version to support because it was never released on PyPI, but I think at this point we should just drop it and (soon) enforce a hard requirement to use vtk>=9.0.

@banesullivan
Copy link
Member Author

should just drop it and (soon) enforce a hard requirement to use vtk>=9.0.

I'm actually thinking vtk>=9.1 due to the NumPy 1.24 incompatibility for <9.1. Ref #3729

@banesullivan banesullivan merged commit b92851d into main Dec 20, 2022
@banesullivan banesullivan deleted the maint/ci-conda-vtk branch December 20, 2022 22:34
@MatthewFlamm
Copy link
Contributor

If we drop CI testing, we should also bump the vtk dependency version.

Is there any benefit to having this conda test now? We still use pip to install this package.

@banesullivan
Copy link
Member Author

Is there any benefit to having this conda test now? We still use pip to install this package.

The conda-forge VTK recipe has a mismatch in enabled modules from the wheel on PyPI. IMO, it makes the most sense to test against the latest conda-forge VTK to ensure PyVista gracefully handles any disabled modules that we have come to expect by default from the PyPI wheel

@banesullivan banesullivan mentioned this pull request Feb 1, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants