-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate and remove PlotterITK #3737
Conversation
Further justification:
Looks like it is incompatoble with numpy 1.24 which gave ample warning about the built-in type aliases going away With this in mind, I'm treating this as a HOTFIX and will merge expeditiously |
CI failure due to needing #3736 |
Codecov Report
@@ Coverage Diff @@
## main #3737 +/- ##
==========================================
- Coverage 94.04% 94.02% -0.02%
==========================================
Files 83 82 -1
Lines 18643 18545 -98
==========================================
- Hits 17532 17437 -95
+ Misses 1111 1108 -3 |
I'm surprised by this breakage since in #3659 (comment) I could get rid of these by upgrading all dependencies... |
I'm also surprised we don't pin the basic dependencies. If numpy were bumped by dependabot we would've seen this coming. |
Oh huh. We don't pin numpy, do we. At first, I thought this was just that we don't pin the conda environment but yeah we don't pin the core dependencies. We may want to look into that seperately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with removing this. This has been broken ever since JupyterLab 3.0, and we have way too many juptyer_backend
s and should start to converge on a consistent backend soon.
Recommending immediate merge to fix the build.
I'm pretty sure no one is actually using this, and it wasn't even registered as a
jupyter_backend
. Maintaining this is more of a burden than a benefit, and there are much better alternatives to this API... like usingitkwidgets
directly which supports PyVista data types!This is in support of #3690
We're going to deprecate and remove this immediately without a transition plan or warning because it is not a core feature and not a proper "jupyter backend"