Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure bounds properties are immutable #3747

Merged
merged 7 commits into from
Jan 3, 2023
Merged

Ensure bounds properties are immutable #3747

merged 7 commits into from
Jan 3, 2023

Conversation

banesullivan
Copy link
Member

Resolves #3147

@github-actions github-actions bot added the bug Uh-oh! Something isn't working as expected. label Dec 24, 2022
@codecov
Copy link

codecov bot commented Dec 24, 2022 •
edited

Codecov Report

Merging #3747 (515286e) into main (0f80086) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3747   +/-   ##
=======================================
  Coverage   94.00%   94.00%           
=======================================
  Files          82       82           
  Lines       18556    18557    +1     
=======================================
+ Hits        17444    17445    +1     
  Misses       1112     1112

MatthewFlamm
MatthewFlamm reviewed Dec 29, 2022
View reviewed changes
Copy link
Contributor

@MatthewFlamm MatthewFlamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than one typing comment.

pyvista/core/composite.py Outdated Show resolved Hide resolved
@adeak adeak changed the title ensure bounds properties are immutable Ensure bounds properties are immutable Dec 29, 2022
@banesullivan banesullivan enabled auto-merge (squash) January 3, 2023 16:55
MatthewFlamm
MatthewFlamm approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@MatthewFlamm MatthewFlamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, typing was likely broken before this PR and shouldn't hold it up.

@banesullivan banesullivan merged commit 75b1656 into main Jan 3, 2023
@banesullivan banesullivan deleted the patch/bounds-tuple branch January 3, 2023 19:02
@adeak adeak mentioned this pull request Jan 3, 2023
Merged
@banesullivan banesullivan mentioned this pull request Feb 1, 2023
Merged
5 tasks
@adeak adeak mentioned this pull request Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adeak adeak adeak left review comments

@MatthewFlamm MatthewFlamm MatthewFlamm approved these changes

Assignees
No one assigned
Labels
bug Uh-oh! Something isn't working as expected.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bounds property return type is mutable from MultiBlock
3 participants
@banesullivan @adeak @MatthewFlamm