Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] update_scalar_bar_range #4035

Merged
merged 1 commit into from
Feb 22, 2023
Merged

[HOTFIX] update_scalar_bar_range #4035

merged 1 commit into from
Feb 22, 2023

Conversation

banesullivan
Copy link
Member

This is a hotfix to address #3615. I do not recommend resolving that issue as update_scalar_bar_range should be moved to the ScalarBars class and this method is missing tests

@github-actions github-actions bot added the bug Uh-oh! Something isn't working as expected. label Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #4035 (746f8f6) into main (3e1bc84) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #4035   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files          97       97           
  Lines       20608    20608           
  Branches     3480     3480           
=======================================
  Hits        19478    19478           
  Misses       1129     1129           
  Partials        1        1           

@banesullivan banesullivan merged commit b0fa031 into main Feb 22, 2023
@banesullivan banesullivan deleted the fix/update-scalar-bars branch February 22, 2023 22:47
banesullivan added a commit that referenced this pull request Feb 22, 2023
larsoner added a commit to larsoner/pyvista that referenced this pull request Mar 2, 2023
* upstream/main: (21 commits)
  Bump trame-vtk from 2.2.1 to 2.2.2 (pyvista#4077)
  [create-pull-request] update local intersphinx (pyvista#4076)
  Bump pydata-sphinx-theme from 0.12.0 to 0.13.0 (pyvista#4074)
  Update pooch requirement from <1.7.0 to <1.8.0 (pyvista#4073)
  Bump trame-vtk from 2.1.0 to 2.2.1 (pyvista#4069)
  Bump trame-client from 2.7.1 to 2.7.3 (pyvista#4070)
  Update imageio requirement from <2.26.0 to <2.27.0 (pyvista#4068)
  Bump trame-vtk from 2.0.17 to 2.1.0 (pyvista#4060)
  Bump trimesh from 3.20.0 to 3.20.1 (pyvista#4061)
  Add bug branch name to bug flag (pyvista#4053)
  Bump trame-client from 2.7.0 to 2.7.1 (pyvista#4058)
  removed _add_row_array (pyvista#4056)
  vtkFiltersParallelDIY2 ModuleNotFoundError -> ImportError (pyvista#4054)
  Fix update_scalar_bar_range (pyvista#4035)
  Fix bug of get_data_range method in Table class. (pyvista#4052)
  Bump scipy from 1.10.0 to 1.10.1 (pyvista#4046)
  Bump mypy from 1.0.0 to 1.0.1 (pyvista#4044)
  Bump pythreejs from 2.4.1 to 2.4.2 (pyvista#4045)
  Add .codacy.yml to exclude examples and tests (pyvista#4011)
  update pre-commit hooks (pyvista#4041)
  ...
@akaszynski akaszynski mentioned this pull request Apr 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Uh-oh! Something isn't working as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant