Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed _add_row_array #4056

Merged

Conversation

Chaitu-Tatipamula
Copy link
Contributor

No description provided.

@tkoyama010 tkoyama010 linked an issue Feb 23, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #4056 (c05dcbd) into main (a11b91b) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4056   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files          97       97           
  Lines       20608    20606    -2     
  Branches     3480     3480           
=======================================
- Hits        19479    19478    -1     
+ Misses       1128     1127    -1     
  Partials        1        1           

Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Chaitu-Tatipamula
Copy link
Contributor Author

LGTM. Thanks!

is that done this process was quite confusing

@tkoyama010
Copy link
Member

Yes. Perfect. Thank you for your contribution. I will merge to the main branch and this work is complete.

@tkoyama010 tkoyama010 merged commit 2486237 into pyvista:main Feb 23, 2023
@tkoyama010 tkoyama010 added the maintenance Low-impact maintenance activity label Feb 23, 2023
@Chaitu-Tatipamula
Copy link
Contributor Author

Yes. Perfect. Thank you for your contribution. I will merge to the main branch and this work is complete.

Oo thanks 😀

@Chaitu-Tatipamula Chaitu-Tatipamula deleted the Chaitu-Tatipamula/pyvista branch February 23, 2023 12:34
@Chaitu-Tatipamula Chaitu-Tatipamula restored the Chaitu-Tatipamula/pyvista branch February 23, 2023 12:34
@Chaitu-Tatipamula Chaitu-Tatipamula deleted the Chaitu-Tatipamula/pyvista branch February 23, 2023 12:34
larsoner added a commit to larsoner/pyvista that referenced this pull request Mar 2, 2023
* upstream/main: (21 commits)
  Bump trame-vtk from 2.2.1 to 2.2.2 (pyvista#4077)
  [create-pull-request] update local intersphinx (pyvista#4076)
  Bump pydata-sphinx-theme from 0.12.0 to 0.13.0 (pyvista#4074)
  Update pooch requirement from <1.7.0 to <1.8.0 (pyvista#4073)
  Bump trame-vtk from 2.1.0 to 2.2.1 (pyvista#4069)
  Bump trame-client from 2.7.1 to 2.7.3 (pyvista#4070)
  Update imageio requirement from <2.26.0 to <2.27.0 (pyvista#4068)
  Bump trame-vtk from 2.0.17 to 2.1.0 (pyvista#4060)
  Bump trimesh from 3.20.0 to 3.20.1 (pyvista#4061)
  Add bug branch name to bug flag (pyvista#4053)
  Bump trame-client from 2.7.0 to 2.7.1 (pyvista#4058)
  removed _add_row_array (pyvista#4056)
  vtkFiltersParallelDIY2 ModuleNotFoundError -> ImportError (pyvista#4054)
  Fix update_scalar_bar_range (pyvista#4035)
  Fix bug of get_data_range method in Table class. (pyvista#4052)
  Bump scipy from 1.10.0 to 1.10.1 (pyvista#4046)
  Bump mypy from 1.0.0 to 1.0.1 (pyvista#4044)
  Bump pythreejs from 2.4.1 to 2.4.2 (pyvista#4045)
  Add .codacy.yml to exclude examples and tests (pyvista#4011)
  update pre-commit hooks (pyvista#4041)
  ...
@akaszynski akaszynski mentioned this pull request Apr 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove _add_row_array in Table class.
2 participants