Fix active scalars and pass point data in to_tetrahedra for RectilinearGrid
#4406
Conversation
It would be better now to use |
Codecov Report
@@ Coverage Diff @@
## main #4406 +/- ##
==========================================
- Coverage 95.82% 95.75% -0.07%
==========================================
Files 97 97
Lines 20874 20887 +13
==========================================
- Hits 20002 20000 -2
- Misses 872 887 +15 |
Let's just change it in this PR and deprecate the old one (safely). I agree that it makes more sense. I know that API changes are generally not considered for patch fixes, but if we safely deprecate, I think we're ok for this release since it's been out in the wild for less than a week. |
This means we should ship this in a patch release quickly. Thanks for fixing the docstring, this also handles not including a specific deprecation warning section, which feels too heavy handed here given the quick deprecation. |
Milestone for v0.39.1 is this Friday. |
…inearGrid` (#4406) * add failing test * fix active scalars for cell data * pass point data, deprecate use of pass_cell_data * document parameter --------- Co-authored-by: Alex Kaszynski <akascap@gmail.com>
* Add PyHyperbolic3D as an external example (#4420) * Add PyHyperbolic3D as an external example * Reduce Gif file size * Use 128 color * optimize and scale --------- Co-authored-by: Alex Kaszynski <akascap@gmail.com> * Fix merge dataset (#4414) * convert back to polydata using extact_geometry * improved readability * branch for performance * add in verts * revert #4407 into this branch * Avoided omission of two letters. --------- Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> * Remove SKIP in docstrings (#4419) * remove SKIPs * remove the rest of skips * minor fixes * Fix active scalars and pass point data in `to_tetrahedra` for `RectilinearGrid` (#4406) * add failing test * fix active scalars for cell data * pass point data, deprecate use of pass_cell_data * document parameter --------- Co-authored-by: Alex Kaszynski <akascap@gmail.com> * Add gif extension to Sphinx-Gallery scraper (#4403) * Add gif extension * Reset cache * Add test for GIFs * Revert cache regeneration * Fix test * use cells for the example --------- Co-authored-by: Alex Kaszynski <akascap@gmail.com> * bump version to v0.39.1 --------- Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> Co-authored-by: MatthewFlamm <39341281+MatthewFlamm@users.noreply.github.com> Co-authored-by: Alex Fernandez <21alex295@gmail.com>
Overview
Closes #4394 by resetting active scalars.
Details
Additionally this PR finds that point data is also not transferred over even though the number of points is maintained. I don't think there is a downside to copying over the point data, so this will be added.