Fix merge dataset #4414
Merged
Fix merge dataset #4414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4414 +/- ##
=======================================
Coverage 95.82% 95.83%
=======================================
Files 97 97
Lines 20875 20909 +34
=======================================
+ Hits 20004 20038 +34
Misses 871 871 |
|
Thanks for addressing this @akaszynski! |
banesullivan
previously approved these changes
May 12, 2023
|
Updated to retain the old behavior when the inputs do not have lines or strips. This helps us retain the "best of both worlds" by using the faster approach when possible, and falling back on the more robust approach when needed. |
|
@akaszynski, I think you merged #4407 into this by accident |
tkoyama010
approved these changes
May 13, 2023
akaszynski
added a commit
that referenced
this pull request
May 16, 2023
* convert back to polydata using extact_geometry * improved readability * branch for performance * add in verts * revert #4407 into this branch * Avoided omission of two letters. --------- Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
akaszynski
added a commit
that referenced
this pull request
May 16, 2023
* Add PyHyperbolic3D as an external example (#4420) * Add PyHyperbolic3D as an external example * Reduce Gif file size * Use 128 color * optimize and scale --------- Co-authored-by: Alex Kaszynski <akascap@gmail.com> * Fix merge dataset (#4414) * convert back to polydata using extact_geometry * improved readability * branch for performance * add in verts * revert #4407 into this branch * Avoided omission of two letters. --------- Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> * Remove SKIP in docstrings (#4419) * remove SKIPs * remove the rest of skips * minor fixes * Fix active scalars and pass point data in `to_tetrahedra` for `RectilinearGrid` (#4406) * add failing test * fix active scalars for cell data * pass point data, deprecate use of pass_cell_data * document parameter --------- Co-authored-by: Alex Kaszynski <akascap@gmail.com> * Add gif extension to Sphinx-Gallery scraper (#4403) * Add gif extension * Reset cache * Add test for GIFs * Revert cache regeneration * Fix test * use cells for the example --------- Co-authored-by: Alex Kaszynski <akascap@gmail.com> * bump version to v0.39.1 --------- Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> Co-authored-by: MatthewFlamm <39341281+MatthewFlamm@users.noreply.github.com> Co-authored-by: Alex Fernandez <21alex295@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #4411 by converting merged
UnstructuredGridsback toPolyDataback usingextract_geometry.There's a performance penalty, but it's worth it since it handles the edge case where we may have an UnstructuredGrid that contains lines or strips.