Fix Trame Viewers in Jupyter #4844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4844 +/- ##
=======================================
Coverage 95.78% 95.78%
=======================================
Files 130 130
Lines 21300 21305 +5
=======================================
+ Hits 20402 20408 +6
+ Misses 898 897 -1 |
|
Thanks @annehaley for the quick PR. And sorry that we didn't test this in our Jupyter environment. I will release 0.42.1 when this PR is merged. |
tkoyama010
approved these changes
Sep 5, 2023
|
LGTM. Thanks for the quick fix @annehaley |
|
I was about to open an issue about #4811 breaking things based on a |
|
@annehaley When you are ready to merge, could you please push the ready for review button? |
tkoyama010
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Add default values for state variables before ui execution * Pass `server` as arg to `get_viewer` in jupyter `initialize` * Fix tests: dont expect a "no data" error from `viewer.export()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is intended to address any oversights from #4811.
Related to #4835.
Changes
BaseViewerclass. This makes calling theuifunction not mandatory for using the viewer.