Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Release 0.42.1 #4848

Merged
merged 3 commits into from
Sep 6, 2023
Merged

🚀 Release 0.42.1 #4848

merged 3 commits into from
Sep 6, 2023

Conversation

tkoyama010
Copy link
Member

@tkoyama010 tkoyama010 commented Sep 6, 2023 •
edited
Loading

Patch release of v0.42.1 which includes:

Merge Checklist

  • Merge in local not to squash merge.

Post Merge Checklist

akaszynski and others added 2 commits September 6, 2023 09:07
@akaszynski @tkoyama010
deploy dev docs on non-tagged push (#4841)
7464719
@annehaley @tkoyama010
Fix Trame Viewers in Jupyter (#4844)
87f1b95 
* Add default values for state variables before ui execution

* Pass `server` as arg to `get_viewer` in jupyter `initialize`

* Fix tests: dont expect a "no data" error from `viewer.export()`
@tkoyama010 tkoyama010 marked this pull request as ready for review September 6, 2023 00:09
@github-actions github-actions bot added maintenance Low-impact maintenance activity release labels Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023 •
edited
Loading

Codecov Report

Merging #4848 (b351345) into release/0.42 (c711f38) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           release/0.42    #4848   +/-   ##
=============================================
  Coverage         95.77%   95.78%           
=============================================
  Files               130      130           
  Lines             21316    21321    +5     
=============================================
+ Hits              20416    20422    +6     
+ Misses              900      899    -1

akaszynski
akaszynski approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking care of this. I'm also fine if we go under 24 hours for this merge.

@tkoyama010
Copy link
Member Author

Thank you for your review. It has been 24 hours since publication. I will release it.

@tkoyama010 tkoyama010 merged commit b351345 into release/0.42 Sep 6, 2023
25 checks passed
@tkoyama010
Copy link
Member Author

Now deploying the document seems to going well, but the page seems not updated yet.
https://github.com/pyvista/pyvista/actions/runs/6103082107/job/16565154300

@tkoyama010
Copy link
Member Author

It seems that size is too big.

Warning: Uploaded artifact size of 6383851520 bytes exceeds the allowed size of 1 GB. Deployment might fail.

https://github.com/pyvista/pyvista-docs/actions/runs/6104131440/job/16569074671#step:2:11

@tkoyama010
Copy link
Member Author

I posted the question ansys/actions#338.

@akaszynski
Copy link
Member

Uncompressed docs are ~600 MB:

$ du -sh doc/_build/html/
584M    doc/_build/html/

I'll have to investigate.

@tkoyama010
Copy link
Member Author

Thanks. I have opened #4868 . Please let us know your mind.

@banesullivan banesullivan deleted the release/0.42.1 branch December 4, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaszynski akaszynski akaszynski approved these changes

Assignees
No one assigned
Labels
maintenance Low-impact maintenance activity release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tkoyama010 @akaszynski @annehaley