New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix connectivity plots in documentation #5307
Fix connectivity plots in documentation #5307
Conversation
github-actions preview |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5307 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 134 134
Lines 22712 22712
=======================================
Hits 21850 21850
Misses 862 862 |
In my opinion, any check that depends on environment should not be in pre-commit. It should be a CI check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Deployed on https://6573a0c8bb457571ba524d6d--tubular-marzipan-5e01ed.netlify.app
Every picture looks fine. Thanks a lot!
@beroda # Get system info
import pyvista as pv
print(pv.Report()) |
@tkoyama010 Here is my
But since the issue concerns |
I'm surprised by this mypy error given you are running python 3.9. deque is included in https://peps.python.org/pep-0585/ which was implemented for 3.9. Are you running pre-commit in the same environment? |
Sorry for the red herring, my |
Good to hear that. |
Resolves #5303