Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connectivity plots in documentation #5307

Merged
merged 4 commits into from Dec 11, 2023

Conversation

beroda
Copy link
Contributor

@beroda beroda commented Dec 8, 2023

Resolves #5303

@github-actions github-actions bot added the bug Uh-oh! Something isn't working as expected. label Dec 8, 2023
@tkoyama010
Copy link
Member

github-actions preview

@beroda
Copy link
Contributor Author

beroda commented Dec 8, 2023

This is weird, I am seeing an unrelated issue with pre-commit locally:
image

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #5307 (bf38360) into main (4c9519b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5307   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files         134      134           
  Lines       22712    22712           
=======================================
  Hits        21850    21850           
  Misses        862      862           

@tkoyama010
Copy link
Member

This is weird, I am seeing an unrelated issue with pre-commit locally: image

Thanks for confirming this locally. You may get pre-commit.ci errors locally in different environments, but if we don't get any errors in CI, you can have them ignored.

Copy link
Contributor

github-actions bot commented Dec 8, 2023

@beroda beroda marked this pull request as ready for review December 9, 2023 12:28
@MatthewFlamm
Copy link
Contributor

In my opinion, any check that depends on environment should not be in pre-commit. It should be a CI check.

Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Deployed on https://6573a0c8bb457571ba524d6d--tubular-marzipan-5e01ed.netlify.app

Every picture looks fine. Thanks a lot!

@tkoyama010
Copy link
Member

This is weird, I am seeing an unrelated issue with pre-commit locally: image

@beroda
Please run the following code wherever you are experiencing the error, and paste the output to comment.
This report helps us track down error and will be critical to addressing your error.

# Get system info
import pyvista as pv
print(pv.Report())

@beroda
Copy link
Contributor Author

beroda commented Dec 10, 2023

@tkoyama010 Here is my pv.Report():

Sun Dec 10 09:57:59 2023 CET
OS Linux CPU(s) 8 Machine x86_64
Architecture 64bit RAM 15.5 GiB Environment Jupyter
File system ext4 GPU Vendor Intel GPU Renderer Mesa Intel(R) HD Graphics 630 (KBL GT2)
GPU Version 4.6 (Core Profile) Mesa 21.2.6 MathText Support False
Python 3.9.18 (main, Aug 25 2023, 13:20:04) [GCC 9.4.0]
pyvista 0.44.dev0 vtk 9.2.6 numpy 1.25.2
matplotlib 3.7.2 scooby 0.7.2 pooch v1.7.0
pillow 10.0.0 imageio 2.33.0 IPython 8.15.0
colorcet 3.0.1 cmocean v3.0.3 ipywidgets 8.1.0
scipy 1.11.4 tqdm 4.66.1 meshio 5.3.4
jupyterlab 4.0.9 pytest_pyvista 0.1.8 trame 3.3.0
trame_client 2.13.0 trame_server 2.13.0 trame_vtk 2.6.2
trame_vuetify 2.3.1 nest_asyncio 1.5.7

But since the issue concerns pre-commit, does the Report helps ? It only shows pyvista deps, not pre-commit ones.
Are you able to reproduce such error locally ?

@MatthewFlamm
Copy link
Contributor

I'm surprised by this mypy error given you are running python 3.9. deque is included in https://peps.python.org/pep-0585/ which was implemented for 3.9. Are you running pre-commit in the same environment?

@beroda
Copy link
Contributor Author

beroda commented Dec 11, 2023

I'm surprised by this mypy error given you are running python 3.9. deque is included in https://peps.python.org/pep-0585/ which was implemented for 3.9. Are you running pre-commit in the same environment?

Sorry for the red herring, my pre-commit + virtualenv configurations were wrong. Everything is fine now
image

@tkoyama010
Copy link
Member

I'm surprised by this mypy error given you are running python 3.9. deque is included in https://peps.python.org/pep-0585/ which was implemented for 3.9. Are you running pre-commit in the same environment?

Sorry for the red herring, my pre-commit + virtualenv configurations were wrong. Everything is fine now image

Good to hear that.

@tkoyama010 tkoyama010 merged commit 3c54651 into pyvista:main Dec 11, 2023
25 checks passed
@tkoyama010 tkoyama010 mentioned this pull request Dec 13, 2023
15 tasks
@banesullivan banesullivan mentioned this pull request Dec 14, 2023
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Uh-oh! Something isn't working as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for connectivity plots are empty
3 participants