Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update plots before scraping" #5310

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Conversation

banesullivan
Copy link
Member

@banesullivan banesullivan enabled auto-merge (squash) December 9, 2023 03:20
@github-actions github-actions bot added maintenance Low-impact maintenance activity dependencies Pull requests that update a dependency file labels Dec 9, 2023
@banesullivan
Copy link
Member Author

I'm reverting this commit as it incorrectly modified our CI routines by setting up graphics capabilities in a test environment specifically for validating that PyVista's core tests will work without graphics. Further this PR added Qt dependencies which we have a policy of not including in PyVista -- anything Qt-specific should be tested in pyvistaqt: https://github.com/pyvista/pyvistaqt

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Merging #5310 (cb9d0d3) into main (f96feb4) will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5310      +/-   ##
==========================================
- Coverage   96.27%   96.20%   -0.07%     
==========================================
  Files         134      134              
  Lines       22700    22712      +12     
==========================================
- Hits        21854    21850       -4     
- Misses        846      862      +16     

@banesullivan banesullivan merged commit f581a23 into main Dec 9, 2023
23 of 25 checks passed
@banesullivan banesullivan deleted the revert-5283-update branch December 9, 2023 03:44
Copy link
Contributor

github-actions bot commented Dec 9, 2023

@github-actions github-actions bot temporarily deployed to pull request December 9, 2023 04:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants