Update plots before scraping

[alexrockhill]

Reimplements #5310.

@banesullivan I think these changes are much more modest and within the scope of the pyvista as opposed to the pyvistaqt library. I'm glad we tested it with qtpy compatibility so that we know this actually works in the original PR but we don't need to keep that all in the PR just to test one line so I think this should be okay now.

[codecov]

Codecov Report

Merging #5321 (332a590) into main (a150a95) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5321      +/-   ##
==========================================
+ Coverage   96.20%   96.27%   +0.06%     
==========================================
  Files         134      134              
  Lines       22718    22706      -12     
==========================================
+ Hits        21856    21860       +4     
+ Misses        862      846      -16     

[banesullivan]

Thanks for taking the time to re-implement and scope down! Sorry for the messy process reverting your original PR. I'll review this ASAP (will be one evening this week) and make sure I:

1. Fully understand the problem you're fixing
2. Am onboard with these changes

[banesullivan]

Generally from a quick glance though this looks good, but I want to dive into the problem you're facing

[alexrockhill]

Thanks for taking the time to re-implement and scope down! Sorry for the messy process reverting your original PR. I'll review this ASAP (will be one evening this week) and make sure I:

1. Fully understand the problem you're fixing

2. Am onboard with these changes

See the very zoomed in plots at the end here for the actual bug: https://mne.tools/mne-gui-addons/auto_examples/ieeg_locate.html#sphx-glr-auto-examples-ieeg-locate-py. The camera view is set using set_camera but that doesn't take effect until after the screenshot is grabbed for the gallery.

[banesullivan]

github-actions preview

[banesullivan]

@ChristosT, since you're the most versed on the scraper at this time (being one of the only other people to modify it), would you please take a quick look at these changes?

[banesullivan]

Just some nitpicky comments, otherwise this looks good! Though, I'd like @ChristosT's feedback if available before merging since they are also modifying the scraper significantly in #4938

[github-actions]

🚀 Deployed on https://6577effbe5dec61453f495af--tubular-marzipan-5e01ed.netlify.app

[ChristosT]

It looks good from my point of view.
It actually makes sense to want to drain the interaction queues before taking a screenshot!

I merged this branch with my changes and built the documentation locally, as far as I checked everything looks good. We just need to be careful when merging because there is a (trivial) merge conflict in sphinx._gallery.py but since I already handled it, we can go ahead and merge this first if every other comment is resolved.

[tkoyama010]

github-actions preview (Edit: I noticed it is already deployed sorry for noise.)

[tkoyama010]

@alexrockhill Thank you for your flexibility in responding to our comments. It is a great contribution.

[github-actions]

🚀 Deployed on https://65791007afab8b3969a85a7a--tubular-marzipan-5e01ed.netlify.app

[alexrockhill]

Thanks for the reviews everyone