Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃挌 Add Ipython test and check it in CI #49

Closed
tkoyama010 opened this issue Aug 18, 2020 · 5 comments
Closed

馃挌 Add Ipython test and check it in CI #49

tkoyama010 opened this issue Aug 18, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@tkoyama010
Copy link
Member

@GuillaumeFavelier Thanks for your review. I am sorry that I could not find erorr of ipython. Could we add Ipython test and check it in CI? (It maybe another issue.)

Originally posted by @tkoyama010 in #40 (comment)
@GuillaumeFavelier GuillaumeFavelier added the enhancement New feature or request label Aug 18, 2020
@GuillaumeFavelier
Copy link
Contributor

I think creating a testing environment with IPython and plot a scene given by _create_testing_scene() would be a good start.

tkoyama010 added a commit to tkoyama010/pyvistaqt that referenced this issue Aug 18, 2020
@tkoyama010
cover ipython in test pyvista#49
597bd07
@tkoyama010 tkoyama010 mentioned this issue Aug 18, 2020
Merged
@tkoyama010 tkoyama010 changed the title Add Ipython test and check it in CI 馃挌 Add Ipython test and check it in CI Aug 18, 2020
@tkoyama010
Copy link
Member Author

tkoyama010 commented Aug 20, 2020 •
edited

It maybe a stupid question 馃槗 But could @pyvista/developers teach me how to make ipython environment in local?

@GuillaumeFavelier
Copy link
Contributor

Sorry if I misunderstand the question.

To start an IPython shell locally, this is what I do:

After installing it with:

$ pip install ipython

or:

$ conda install ipython

I just type:

$ ipython

Then I obtain the following:

Python 3.8.3 (default, May 19 2020, 18:47:26) 
Type 'copyright', 'credits' or 'license' for more information
IPython 7.14.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]:

@tkoyama010
Copy link
Member Author

@GuillaumeFavelier This is exactry what I want to know. My concern was that it might require special procedures for pyvistaqt. Thanks.

larsoner pushed a commit that referenced this issue Sep 22, 2020
@tkoyama010 @GuillaumeFavelier
馃挌 Add Ipython test and check it in CI (#51)
f3d3a21 
* cover ipython in test #49

* TST: Add a basic test in IPython

* Add ipython to requirements_test.txt

* TST: Try with off_screen=False

* TST: Try with show=False

* TST: Try with qapp

* 馃摝 qscintilla

* Revert qscintilla

* Add SystemExit

* Remove SystemExit

* Fix error of QtGui

* 馃摝 Update PyQt5 version

* Revert "馃摝 Update PyQt5 version"

This reverts commit 557aabf.

* skip ipython test of Python3.8 on Windows

* Fix pylint

Co-authored-by: Guillaume Favelier <guillaume.favelier@gmail.com>
@GuillaumeFavelier
Copy link
Contributor

Closing by #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tkoyama010 @GuillaumeFavelier