Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃挌 Add Ipython test and check it in CI #51

Merged
merged 16 commits into from Sep 22, 2020
Merged

馃挌 Add Ipython test and check it in CI #51

merged 16 commits into from Sep 22, 2020

Conversation

tkoyama010
Copy link
Member

See #49

@tkoyama010 tkoyama010 changed the title cover ipython in test #49 Add Ipython test and check it in CI Aug 18, 2020
@tkoyama010 tkoyama010 changed the title Add Ipython test and check it in CI 馃挌 Add Ipython test and check it in CI Aug 18, 2020
@codecov
Copy link

codecov bot commented Aug 18, 2020 •
edited

Codecov Report

Merging #51 into master will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   97.92%   98.06%   +0.13%     
==========================================
  Files           5        6       +1     
  Lines         434      516      +82     
==========================================
+ Hits          425      506      +81     
- Misses          9       10       +1

@GuillaumeFavelier
Copy link
Contributor

@tkoyama010 I committed 9af5519 to test the CIs

@tkoyama010
Copy link
Member Author

tkoyama010 commented Aug 20, 2020 •
edited

I added ipython to install.

@GuillaumeFavelier
Copy link
Contributor

GuillaumeFavelier commented Aug 20, 2020 •
edited

The failures on Windows Python38-64bit and macOS Python37 seem to happen consistently (both eb90843 and
f4c08a3).

@tkoyama010
Copy link
Member Author

I have windows environment. So I could do the test of windows.

@GuillaumeFavelier
Copy link
Contributor

So I could do the test of windows.

That would be awesome :)

Meanwhile I will do 2 more tests with the CIs:

  1. with the qapp fixture so that pytest-qt manages the QApplication
  2. with show=False

@GuillaumeFavelier
Copy link
Contributor

My changes didn't improve the situation

@tkoyama010
Copy link
Member Author

tkoyama010 commented Sep 21, 2020 •
edited

鈽濓笍 From https://stackoverrun.com/ja/q/11883985. (P.S. Seems not working. I reverted.)

@tkoyama010 tkoyama010 marked this pull request as ready for review September 21, 2020 18:02
@tkoyama010 tkoyama010 marked this pull request as draft September 21, 2020 18:06
@tkoyama010
Copy link
Member Author

tkoyama010 commented Sep 22, 2020 •
edited

I reporoduce the error in Python3.8 in Windows10. It is the bug of PyQt5.
https://www.riverbankcomputing.com/pipermail/pyqt/2020-September/043160.html

@tkoyama010
Copy link
Member Author

tkoyama010 commented Sep 22, 2020 •
edited

馃啓 Let's split PyQt5 version up Pull Request.

@tkoyama010 tkoyama010 mentioned this pull request Sep 22, 2020
Closed
@tkoyama010 tkoyama010 marked this pull request as ready for review September 22, 2020 03:32
@tkoyama010
Copy link
Member Author

This is ready for reviews @pyvista/developers @GuillaumeFavelier

larsoner
larsoner approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward so I'll merge, but @GuillaumeFavelier feel free to look when you get a chance

@larsoner larsoner merged commit f3d3a21 into pyvista:master Sep 22, 2020
@larsoner
Copy link
Contributor

Thanks @tkoyama010 !

@tkoyama010
Copy link
Member Author

Thanks

@tkoyama010 tkoyama010 deleted the patch-4 branch September 22, 2020 13:31
@GuillaumeFavelier GuillaumeFavelier mentioned this pull request Jan 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsoner larsoner larsoner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tkoyama010 @GuillaumeFavelier @larsoner