Switch versioning system to use autover #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have released 1.5.0a1 here using this PR (and pushed the tag). As far as I can tell, the tests are only failing because of a few flake issues. |
|
@philippjfr I think this is ready to review/merge when the tests pass and when you confirm that the alpha works as expected. |
|
I think this PR is now ready to review/merge. |
philippjfr
reviewed
Mar 12, 2018
| @@ -0,0 +1,2 @@ | |||
| __init__.py export-subst | |||
| setup.py export-subst | |||
There was a problem hiding this comment.
Newlines here and in .gitignore would be nice, but won't let it hold up the PR.
There was a problem hiding this comment.
Addressed in 3efb09f
|
One minor comment about newlines, I'll let you decide what to do, happy to merge either way. |
|
Addressed your comment and the tests are green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to switch geoviews to autover, following the corresponding PR in holoviz/holoviews#2426. Embedding version.py until it is available via param.
The only thing I'm not entirely sure about is whether a MANIFEST will need to be added for the
.versionfile.