Enabled matplotlib layout fix by default #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree...though how did you come up with the new vspace value? Trial and error? |
Yeah, just like the previous value, it should behave more predictably now though. I'm not quite sure why the tests are still passing. Will have to review the test data. |
|
The tests have now passed. Are the tests updated reviewed making this PR ready to merge? |
|
No, for some reason the test data hasn't changed and I can't figure out why. |
|
It might be worth thinking about how this links to #1041 before merging... |
|
And yes, the fact the tests kept passing is weird! |
|
I guess just merge it, can always revert it if something goes wrong. |
|
Ok. Hope it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's time to enable the matplotlib layout fix by default. There will be changes to the display data, so that will have to be updated, after careful review.