Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled matplotlib layout fix by default #1037

Merged
merged 2 commits into from
Jan 17, 2017
Merged

Conversation

philippjfr
Copy link
Member

It's time to enable the matplotlib layout fix by default. There will be changes to the display data, so that will have to be updated, after careful review.

@jlstevens
Copy link
Contributor

I agree...though how did you come up with the new vspace value? Trial and error?

@philippjfr
Copy link
Member Author

I agree...though how did you come up with the new vspace value? Trial and error?

Yeah, just like the previous value, it should behave more predictably now though. I'm not quite sure why the tests are still passing. Will have to review the test data.

@jlstevens
Copy link
Contributor

The tests have now passed. Are the tests updated reviewed making this PR ready to merge?

@philippjfr
Copy link
Member Author

No, for some reason the test data hasn't changed and I can't figure out why.

@jlstevens
Copy link
Contributor

It might be worth thinking about how this links to #1041 before merging...

@jlstevens
Copy link
Contributor

And yes, the fact the tests kept passing is weird!

@philippjfr
Copy link
Member Author

I guess just merge it, can always revert it if something goes wrong.

@jlstevens
Copy link
Contributor

Ok. Hope it works!

@jlstevens jlstevens merged commit 18b87e1 into master Jan 17, 2017
@philippjfr philippjfr deleted the layout_fix_enable branch January 27, 2017 02:53
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants