Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept lists in Path #1050

Merged
merged 1 commit into from
Feb 23, 2017
Merged

Accept lists in Path #1050

merged 1 commit into from
Feb 23, 2017

Conversation

basnijholt
Copy link
Contributor

@basnijholt basnijholt commented Jan 11, 2017 •
edited
Loading

The following code now works:

import holoviews as hv
hv.notebook_extension()

x = range(10)
y = range(10)
hv.Curve((x, y)) + hv.Path((x, y)) + hv.Contours((x, y))

@philippjfr
Copy link
Member

Looks good, will merge when tests pass.

@philippjfr
Copy link
Member

Will investigate why tests are failing.

philippjfr
philippjfr reviewed Feb 23, 2017
View reviewed changes
holoviews/element/path.py Outdated
@@ -38,7 +38,7 @@ class Path(Element2D):

def __init__(self, data, **params):
if isinstance(data, tuple):
x, y = data
x, y = map(np.asarray, *data)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should just be map(np.asarray, data), could you fix it, then I'll merge asap.

@basnijholt
Copy link
Contributor Author

Thanks, done :)

@philippjfr
Copy link
Member

Thank you! Ready to merge.

@philippjfr philippjfr merged commit e981ed1 into holoviz:master Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippjfr philippjfr philippjfr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@basnijholt @philippjfr