-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve hover tool behavior on Curve types #1092
Conversation
Why is I'm not sure how to parse 'Element: 4'; is that the 4th curve from the bottom? Could you maybe assign names or values to the curves in the example, so that we can see that the name/value of that curve will be shown (hopefully true?)? Also, apart from the name/value of the curve, presumably what we really want to see is the values of all other dimensions not mapped to the screen, at that point of that curve. I guess that's not possible? Presumably that's shown in the non-batched case? Would be good to clarify that, and to put that in the docs. |
Ok, that looks good. Presumably the second |
I've fixed that and renamed the dimension the Curves are indexed by to 'z' in the example.
In the non-batched case that will work all dimensions associated which each curve sample will be shown. In the batched case we will unfortunately only see the NdOverlay dimensions and values. |
Sounds good, thanks! Worth explaining anywhere we explain batched=True. Not sure why one can't do a lookup of whatever data we want to show, knowing the coordinates, but I guess that would turn this into something needing streams, whereas you are talking about Bokeh's native JS-based hover support? |
06a54b9
to
2662ce0
Compare
Right, indeed I don't really know how to modify the hover labels even using dynamic callbacks yet. This is purely about default |
Ready to merge when tests pass. |
Unfortunately, the new |
Ah, both a python3 issue and outdated test, will push shortly. |
This was an actual bug in the hover code in python3, hover was broken in some cases. |
Good to have unit tests. |
Ready to merge again. |
Looks good. Merging. |
Fixes #986. Unfortunately in batched mode the hover tool will show all the values in the curve array rather than the specific coordinate you are hovering over so I've disabled displaying curve dimensions when in batched mode.
Batched:
Non-batched: