Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply matplotlib rc parameters correctly throughout #1225

Merged
merged 2 commits into from
Mar 24, 2017
Merged

Conversation

philippjfr
Copy link
Member

I've long struggled with the correct way to apply rcparams in matplotlib, I now think a decorator which is applied during axis/figure creation, for all initialize_plot and update_frame calls and during rendering is the best approach.

Fixes #1222

@philippjfr philippjfr added type: bug Something isn't correct or isn't working tag: backend: mpl labels Mar 23, 2017
@philippjfr
Copy link
Member Author

Ready for review.

@jlstevens
Copy link
Contributor

jlstevens commented Mar 23, 2017

Seems like a sensible approach and I am happy with it as long as it works - preferably better than before!

My only comment is that I think mpl_context should be called mpl_rc_context to be explicit.

@jlstevens
Copy link
Contributor

I suppose my only other comment is that it might be nice to test - if it is easy enough to set up such tests.

Copy link
Contributor

@jlstevens jlstevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just rename mpl_context to mpl_rc_context and consider adding some tests if possible. Otherwise looks good.

@philippjfr philippjfr force-pushed the mpl_rc_context branch 2 times, most recently from 4f6b75f to 4e040be Compare March 23, 2017 17:08
@philippjfr
Copy link
Member Author

Ready now, pretty sure the coverage report is false, when I click through to it, it doesn't actually tell me which files now have reduced coverage.

@jlstevens
Copy link
Contributor

Ready now, pretty sure the coverage report is false

Yeah, a -1.4% coverage change is surprising.

Anyway, looks good and I'll now merge.

@jlstevens jlstevens merged commit 8974ed1 into master Mar 24, 2017
@philippjfr philippjfr deleted the mpl_rc_context branch April 11, 2017 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: backend: mpl type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants