-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply matplotlib rc parameters correctly throughout #1225
Conversation
Ready for review. |
Seems like a sensible approach and I am happy with it as long as it works - preferably better than before! My only comment is that I think |
I suppose my only other comment is that it might be nice to test - if it is easy enough to set up such tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just rename mpl_context
to mpl_rc_context
and consider adding some tests if possible. Otherwise looks good.
4f6b75f
to
4e040be
Compare
4e040be
to
c554db1
Compare
Ready now, pretty sure the coverage report is false, when I click through to it, it doesn't actually tell me which files now have reduced coverage. |
Yeah, a -1.4% coverage change is surprising. Anyway, looks good and I'll now merge. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I've long struggled with the correct way to apply rcparams in matplotlib, I now think a decorator which is applied during axis/figure creation, for all
initialize_plot
andupdate_frame
calls and during rendering is the best approach.Fixes #1222