Fixes for pandas 0.20(.1) compatibility #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to merge. |
|
Looks good. Before I merge, I do want to ask how far back (in pandas versions) these changes will work with. If we now require the pandas version to be more recent than some release, we should put that in setup.py and meta.yml. |
I've gone back to 0.16.1 which was released in May 2015 without issues. My guess is |
|
Sounds good. A few people might still be using a version of pandas older than 2 years but it won't be a big worry. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1410 avoiding imports from
pandas.tsliband replacing a usage ofdf.ixwhich have both been deprecated.