Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histogram improvements #1836

Merged
merged 15 commits into from Oct 31, 2017

Conversation

Projects
None yet
3 participants
@philippjfr
Copy link
Contributor

philippjfr commented Aug 31, 2017

Cleaned up and made various outstanding fixes for PR #1784.

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Sep 1, 2017

@jlstevens I've now got this passing. Do you still want a label_format parameter as you suggested in the original PR?

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Sep 1, 2017

I still think the label_format idea is a good one, so it would be nice to include if it doesn't add too much additional work.

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Sep 1, 2017

Not sure I like label_format for this, since it's the value dimension label but could be confused with the regular label. Not sure I have much better suggestions though since I don't like vdim_label.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Sep 1, 2017

So your issue is not with the idea, just the parameter name? How aboutbinned_format or aggregate_label or something like that?

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Sep 1, 2017

frequency_format is probably the most correct. Is that too long?

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Sep 1, 2017

It is a bit long but I think it is ok. I'll try to think of something shorter but if I can't come up with anything, it will do.

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Sep 1, 2017

Actually I probably prefer frequency_label.

@philippjfr philippjfr force-pushed the histogram-improve branch 3 times, most recently from f90225c to ea21bb5 Sep 29, 2017

@philippjfr philippjfr force-pushed the histogram-improve branch from ea21bb5 to b6f9651 Oct 31, 2017

@philippjfr philippjfr force-pushed the histogram-improve branch from b6f9651 to e36f86a Oct 31, 2017

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Oct 31, 2017

Tests are now passing (apart from a single transient), so I'll merge. @timothydmorton Thanks again for contributing, sorry this took so long to merge but it'll be in the next release.

@philippjfr philippjfr merged commit 2782cfd into master Oct 31, 2017

3 of 4 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 79.858%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the histogram-improve branch Nov 2, 2017

@pyup-bot pyup-bot referenced this pull request Nov 3, 2017

Closed

Update holoviews to 1.9.0 #104

@pyup-bot pyup-bot referenced this pull request Nov 13, 2017

Closed

Update holoviews to 1.9.1 #120

@pyup-bot pyup-bot referenced this pull request Dec 12, 2017

Merged

Update holoviews to 1.9.2 #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.