Datashader fixes #2344
Merged
Datashader fixes #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, but so did the old buggy way. :-/ |
philippjfr
force-pushed
the
datashader_dt_fixes
branch
from
1457cc9
to
e13a25c
Compare
philippjfr
force-pushed
the
datashader_dt_fixes
branch
from
e13a25c
to
eb66d1b
Compare
|
@jlstevens Ready to merge. Once you have I'll cherry-pick it onto the hotfix branch. |
|
Looks good. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses another bug in the datashader handling of datetimes, when the range is not supplied with nanosecond resolution. Also adds a test and some extra handling for datashading empty objects.