Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datashader fixes #2344

Merged
merged 3 commits into from Feb 16, 2018
Merged

Datashader fixes #2344

merged 3 commits into from Feb 16, 2018

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Feb 15, 2018

Addresses another bug in the datashader handling of datetimes, when the range is not supplied with nanosecond resolution. Also adds a test and some extra handling for datashading empty objects.

@jbednar
Copy link
Member

@jbednar jbednar commented Feb 15, 2018

Looks good to me, but so did the old buggy way. :-/

@philippjfr philippjfr force-pushed the datashader_dt_fixes branch from 1457cc9 to e13a25c Feb 15, 2018
@philippjfr philippjfr force-pushed the datashader_dt_fixes branch from e13a25c to eb66d1b Feb 15, 2018
@philippjfr philippjfr requested a review from jlstevens Feb 15, 2018
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Feb 16, 2018

@jlstevens Ready to merge. Once you have I'll cherry-pick it onto the hotfix branch.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Feb 16, 2018

Looks good. Merging.

@jlstevens jlstevens merged commit ff47ad1 into master Feb 16, 2018
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.007%) to 82.074%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
philippjfr added a commit that referenced this pull request Feb 16, 2018
@philippjfr philippjfr deleted the datashader_dt_fixes branch Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants