Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph.from_networkx method now extract node and edge attributes #2714

Merged
merged 3 commits into from May 22, 2018

Conversation

Projects
None yet
3 participants
@philippjfr
Copy link
Contributor

philippjfr commented May 22, 2018

This PR will allow the Graph.from_networkx method to extract any attributes defined on the nodes and edges and also fixes a bug when trying to plot a Graph with no edges (i.e. only nodes).

Philipp Rudiger Philipp Rudiger

@philippjfr philippjfr added the bug label May 22, 2018

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented May 22, 2018

Ready to review/merge.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented May 22, 2018

Looks good. Merging.

@jlstevens jlstevens merged commit 8ce2f52 into master May 22, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 83.509%
Details
s3-reference-data-cache Test data is cached.
Details
@soerendip

This comment has been minimized.

Copy link

soerendip commented May 22, 2018

I just cloned and installed holoviews. I still get the same error, when plotting without edges. Am I missing something? Clone the repo and python setup.py install?

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented May 22, 2018

What does hv.__version__ report? Your example definitely seems to work for me:

screen shot 2018-05-23 at 12 02 02 am

@soerendip

This comment has been minimized.

Copy link

soerendip commented May 22, 2018

Ok, confirmed it works. Not sure what went wrong the last time.

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented May 23, 2018

Thanks for confirming!

@philippjfr philippjfr referenced this pull request May 24, 2018

Merged

Minor bug fix for adding custom node attributes #2723

1 of 1 task complete

@philippjfr philippjfr deleted the graph_networkx_enhancements branch Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.