Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug adding dimension to XArrayInterface #2761

Merged
merged 2 commits into from Jun 4, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Jun 1, 2018

The XArrayInterface.add_dimension method was assuming that the underlying xarray Dataset dimension ordering would be the same as the dimensions on the hv.Dataset, which does not have to be the case. This PR ensures that the dimensions are declared in the correct order.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Jun 1, 2018

Looks good. Happy to merge once the unit tests are ready and passing.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Jun 4, 2018

Tests are green now. Ready to merge?

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Jun 4, 2018

Yes, go ahead.

@jlstevens jlstevens merged commit 7b28246 into master Jun 4, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0007%) to 82.837%
Details
s3-reference-data-cache Tests passing no test data changes required.
Details

@philippjfr philippjfr deleted the xarray_add_dimension_fix branch Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.