Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-finite range in datashader operations #2863

Merged
merged 3 commits into from Jul 7, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Jul 7, 2018

Non-finite ranges in the datashader operation were being given special treatment by defining a fake range. This is incompatible with the bounds and density validation so just like the zero-range case it will now actually use an empty range.

Additionally this PR adds support for zero-ranges to the ImageInterface.

Philipp Rudiger Philipp Rudiger

@philippjfr philippjfr force-pushed the empty_ds_agg branch from 33509af to 7d9cfe9 Jul 7, 2018

@jbednar

jbednar approved these changes Jul 7, 2018

Copy link
Contributor

jbednar left a comment

Looks good as far as I can tell.

@philippjfr philippjfr merged commit d33d5b7 into master Jul 7, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on empty_ds_agg at 82.946%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the empty_ds_agg branch Aug 5, 2018

@philippjfr philippjfr added this to the v1.10.8 milestone Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.