Various fixes for bokeh datetime handling #3005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
philippjfr
commented
Sep 17, 2018
philippjfr
commented
- Fixes datetime formatting in Table
- Fixes datetime formatting in Path hover
- Fix datetime formatting in Chart hover
- Add unit tests
philippjfr
added
type: bug
|
Does this also fix Spikes hover #2882 |
|
It does now. |
philippjfr
force-pushed
the
datetime_bokeh_fixes
branch
from
6af7e8d
to
77aa9aa
Compare
philippjfr
force-pushed
the
datetime_bokeh_fixes
branch
from
77aa9aa
to
d775c70
Compare
|
Looks good. I'll merge when the tests pass. |
philippjfr
added a commit
that referenced
this pull request
Oct 25, 2018
# Conflicts: # holoviews/plotting/bokeh/path.py # holoviews/plotting/plot.py # holoviews/plotting/util.py # tests/plotting/bokeh/testpathplot.py # tests/plotting/bokeh/testpointplot.py # tests/plotting/bokeh/testspikesplot.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.