Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use robust isfinite utility throughout #3045

Merged
merged 4 commits into from Oct 5, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Oct 4, 2018

We use np.isfinite in many places across the code, however the numpy version of this function is not robust to many different types which is why we created the hv.core.util.isfinite utility. Unfortunately this is not yet used everywhere throughout the code, leading to bugs like #3044 and #3040

  • Add unit tests

@philippjfr philippjfr added the bug label Oct 4, 2018

@philippjfr philippjfr force-pushed the robust_isfinite branch from 30e4968 to 1cfe7e4 Oct 5, 2018

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Oct 5, 2018

Ready to review and merge.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Oct 5, 2018

Looks good and the tests are green. Merging.

@jlstevens jlstevens merged commit f2a47f7 into master Oct 5, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 83.144%
Details
s3-reference-data-cache Test data is cached.
Details

philippjfr added a commit that referenced this pull request Oct 25, 2018

Use robust isfinite utility throughout (#3045)
# Conflicts:
#	holoviews/core/util.py
#	holoviews/element/raster.py
#	holoviews/operation/stats.py
#	holoviews/plotting/bokeh/stats.py
#	tests/plotting/bokeh/testareaplot.py

@philippjfr philippjfr added this to the v1.10.8 milestone Oct 25, 2018

@philippjfr philippjfr deleted the robust_isfinite branch Nov 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.