Use robust isfinite utility throughout #3045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
robust_isfinite
branch
from
30e4968
to
1cfe7e4
Compare
|
Ready to review and merge. |
|
Looks good and the tests are green. Merging. |
This was referenced Oct 5, 2018
philippjfr
added a commit
that referenced
this pull request
Oct 25, 2018
# Conflicts: # holoviews/core/util.py # holoviews/element/raster.py # holoviews/operation/stats.py # holoviews/plotting/bokeh/stats.py # tests/plotting/bokeh/testareaplot.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use np.isfinite in many places across the code, however the numpy version of this function is not robust to many different types which is why we created the
hv.core.util.isfiniteutility. Unfortunately this is not yet used everywhere throughout the code, leading to bugs like #3044 and #3040