Simplify CI setup and environment #3056
Conversation
|
pillow-5.3.0 is not ok ? |
|
We're seeing some issues with matplotlib gif rendering. For now this is just a test if this is really the cause. |
|
Doesn't appear to be the issue. |
|
The issue is probably an change in matplotlib 2.2.3 in that case. |
philippjfr
force-pushed
the
pin_pillow
branch
6 times, most recently
from
1a5678d
to
cbd46ed
Compare
|
@jbednar @jlstevens I haven't been able to track down precisely what the cause of the gif export error was, pinning matplotlib and pillow to older versions individually did not work but now I'm pinning both of them it is working again. As such I'm going to merge this PR soon, but I'll quickly describe what I've done. This PR is intended as a stepping stone towards slowly moving to @ceball's fabulous new architecture. I've moved all the dependencies out of the .travis.yml into the environment.yml which has long been unused. The environment.yml is much more readable and makes it clear just how much we're pinning right now. We should try to slowly lift the pinned versions while keeping the tests passing. Once we can have our testing setup work on the latest releases the transition to the new architecture should be much easier and cleaner. One thing to note here is that the environment.yml does not define a python version, which means that at least on travis the only way we are getting both py2 and py3 tests is that we are installing Miniconda and Miniconda3, which then determines the python version of the environment while the exact |
|
Just a quick comment to say I am happy with the changes Philipp made in this PR: we want to minimize travis.yml as much as possible! |
No description provided.