Improved handling of JS and CSS dependencies #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| js_dependencies = Renderer.js_dependencies + CDN.js_files | ||
|
|
||
| css_dependencies = Renderer.css_dependencies + CDN.css_files | ||
| backend_dependencies = {'js': CDN.js_files, 'css': CDN.css_files} |
There was a problem hiding this comment.
Definitely cleaner. I assume you'll collect the core renderer dependencies together later...
|
Looks good to me as soon as you address the comments I've made. |
|
Thanks for the fix. Merging. |
jlstevens
added a commit
that referenced
this pull request
Feb 1, 2016
Improved handling of JS and CSS dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt at making the handling of JS and CSS dependencies a bit more sane to allow exporting of notebooks and individual widgets more easily and ensure sufficient control over which libraries are included.