Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up Panes and added tests #18

Merged
merged 10 commits into from
Sep 4, 2018
Merged

Cleaned up Panes and added tests #18

merged 10 commits into from
Sep 4, 2018

Conversation

philippjfr
Copy link
Member

  • Cleaned up Pane.applies implementations
  • Add Pane tests

@codecov-io
Copy link

codecov-io commented Sep 4, 2018

Codecov Report

Merging #18 into master will increase coverage by 7.15%.
The diff coverage is 94.2%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   85.06%   92.21%   +7.15%     
==========================================
  Files          15       17       +2     
  Lines        1808     2069     +261     
==========================================
+ Hits         1538     1908     +370     
+ Misses        270      161     -109
Impacted Files Coverage Δ
setup.py 0% <ø> (ø) ⬆️
panel/tests/test_util.py 100% <100%> (ø)
panel/tests/fixtures.py 100% <100%> (ø) ⬆️
panel/util.py 77.14% <66.66%> (+26.18%) ⬆️
panel/panes.py 82.57% <66.66%> (+40.49%) ⬆️
panel/tests/test_panes.py 97.93% <97.93%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 931cc6a...45e2f4f. Read the comment docs.

@philippjfr philippjfr merged commit ee8f115 into master Sep 4, 2018
@philippjfr philippjfr deleted the pane_improvements branch September 4, 2018 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants