Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change key names for reading Solomon instances #42

Closed
leonlan opened this issue Jan 12, 2023 · 1 comment · Fixed by #48
Closed

Change key names for reading Solomon instances #42

leonlan opened this issue Jan 12, 2023 · 1 comment · Fixed by #48
Labels
enhancement New feature or request

Comments

@leonlan
Copy link
Member

leonlan commented Jan 12, 2023

https://github.com/leonlan/CVRPLIB/blob/46b444e61f8e5f72a87aa7f36fc72bb40a3729d1/cvrplib/parse/parse_solomon.py#L28-L39

The key names should not be altered but instead follow the exact names from the instance data.
@leonlan leonlan added the enhancement New feature or request label Jan 12, 2023
@leonlan leonlan mentioned this issue Jan 29, 2023
Closed
@leonlan
Copy link
Member Author

leonlan commented Feb 1, 2023

Instead of following the exact names from the instance data, #48 makes the instance field names consistent VRPLIB.

@leonlan leonlan mentioned this issue Feb 1, 2023
Merged
leonlan pushed a commit that referenced this issue Feb 1, 2023
@wouterkool
Make fieldnames consistent among vrplib and Solomon format (#48)
bec0627 
Co-authored-by: Wouter Kool <1150455+wouterkool@users.noreply.github.com>
Co-authored-by: Leon Lan <30997278+leonlan@users.noreply.github.com>
Closes #42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@leonlan